Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for getting and editing integration_types_config application field #9818

Merged
merged 6 commits into from
Feb 18, 2025

Conversation

Soheab
Copy link
Contributor

@Soheab Soheab commented May 5, 2024

Summary

This PR adds support for getting and editing the integration_types_config field for applications.

I exposed it as default_x_install_params properties instead of an object that parses it because I find the inner oauth2_install_params object very unnecessary.

Something to note, setting default_guild_install_x and not default_user_install_x will disable default_user_install_x and I'm not sure if discord.py should handle or tell the user that, if, where and how.

Relevant API Docs:

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. This API feels.. kinda stinky to be blunt. It's overly verbose and repetitive but I'm unsure how to make it better as it stands. Maybe the separate objects would be cleaner, I don't know.

@Rapptz Rapptz added the needs review This PR will be reviewed in the future label Feb 17, 2025
@Rapptz Rapptz merged commit fa158a5 into Rapptz:master Feb 18, 2025
8 checks passed
@Rapptz Rapptz removed the needs review This PR will be reviewed in the future label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants